Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix ticket form's width #2096

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Fix ticket form's width #2096

merged 1 commit into from
Jan 2, 2023

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Jan 2, 2023

/problem/aplusb/tickets/new
On narrow screens, width: 100%; causes overflow and looks bad.

@codecov-commenter
Copy link

Codecov Report

Base: 46.69% // Head: 46.68% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0116ac7) compared to base (3947d2b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2096      +/-   ##
==========================================
- Coverage   46.69%   46.68%   -0.01%     
==========================================
  Files         238      238              
  Lines       13236    13234       -2     
==========================================
- Hits         6180     6178       -2     
  Misses       7056     7056              
Impacted Files Coverage Δ
judge/utils/unicode.py 52.17% <0.00%> (-3.83%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it looks like with this change + narrow screen, there is more padding on the left side than the right?

@Xyene Xyene merged commit a5eb182 into DMOJ:master Jan 2, 2023
@int-y1 int-y1 deleted the ticket-width branch January 2, 2023 20:53
@int-y1
Copy link
Contributor Author

int-y1 commented Jan 2, 2023

LGTM, but it looks like with this change + narrow screen, there is more padding on the left side than the right?

This affects other forms too. Forms have 15px left pad, and 10px right pad, because of

.form-area {
display: inline-block;
background: $color_primary5;
padding: 5px 10px 10px 15px;
border-radius: $widget_border_radius;
border: 1px solid $color_primary25;
}

I suspect that this is a typo that wasn't corrected.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants