Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use a simpler activation email template #719

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Conversation

Xyene
Copy link
Member

@Xyene Xyene commented Sep 30, 2018

This is superior to the horrifyingly bad HTML/CSS one currently in use, that doesn't even display the site name correctly. Addresses #560.

@Xyene Xyene requested a review from quantum5 September 30, 2018 18:50
Copy link
Member

@quantum5 quantum5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix those, and assuming you have seen the email, it would be ready to merge.

<div style="display:block;margin: 0 2px;padding: 1em;border: 3px solid #2980B9;background-color: #f8f8f8;border-radius: 6px;font-size: .95em;color: #444;">
<b>Thanks for registering on the {{ site.name }}! We're glad to have you.</b>
<br><br>
The last step is activating your account. Please activate your {{ SITE_NAME }} account in the next {{ expiration_days }} days.a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I highly doubt the trailing a is intended.

@Xyene Xyene force-pushed the simple-activation-email branch from a446cb5 to 8a2c1e8 Compare September 30, 2018 19:21
This is superior to the horrifyingly bad HTML/CSS one currently in use, that doesn't even display the site name correctly.
@Xyene Xyene force-pushed the simple-activation-email branch from 8a2c1e8 to d1f6360 Compare September 30, 2018 19:24
@Xyene Xyene merged commit 5ec867f into master Oct 1, 2018
@Xyene Xyene deleted the simple-activation-email branch December 17, 2018 00:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants