Google analytics #2534
Google analytics #2534
Conversation
config/application.rb
Outdated
| @@ -122,6 +122,9 @@ class Application < Rails::Application | |||
| config.branding = config_for(:branding).deep_symbolize_keys | |||
| end | |||
|
|
|||
| # org abbreviation for the root google analytics tracker that gets planted on every page | |||
| config.tracker_root = "UoE" | |||
There was a problem hiding this comment.
Probably want something more generic here like 'DMPRoadmap' so that other installations aren't using UoE by default.
There was a problem hiding this comment.
Agh! that wasn't intentional
| @@ -64,6 +64,10 @@ class Org < ActiveRecord::Base | |||
|
|
|||
| belongs_to :region | |||
|
|
|||
| has_one :tracker | |||
| accepts_nested_attributes_for :tracker | |||
| validates_associated :tracker | |||
There was a problem hiding this comment.
Nice! I did not know about this validates_associated.
can you add a dependent: :destroy' to the has_one` statement? This should prevent any orphaning of records
spec/models/tracker_spec.rb
Outdated
| require 'rails_helper' | ||
|
|
||
| RSpec.describe Tracker, type: :model do | ||
| pending "add some examples to (or delete) #{__FILE__}" |
There was a problem hiding this comment.
Would be great to add some simple tests here. Check out some of the other model tests like spec/models/contributor_spec.rb for examples of association and validation tests.
You can test that enum with something like this: it { is_expected.to define_enum_for(:category).with(Identifier.categories.keys) }
Fixes #2344 .
Changes proposed in this PR: