Clean up minor x.509 issues #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
steven-bellock
commented
Dec 12, 2024
steven-bellock
commented
- Add explicit NULL check.
- Fix typos.
- Make documentation and implementation consistent.
- Add explicit NULL check. - Fix typos. - Make documentation and implementation consistent. Signed-off-by: Steven Bellock <sbellock@nvidia.com>
steven-bellock
added
documentation
|
These issues were found by the NVIDIA CI/CD system. |
jyao1
reviewed
Dec 16, 2024
Comment on lines
+207
to
+212
| if (x509_cert == NULL) { | ||
| return; | ||
| } | ||
|
|
||
| mbedtls_x509_crt_free(x509_cert); | ||
| free_pool(x509_cert); |
There was a problem hiding this comment.
I don't understand the change.
What is the problem of original code?
There was a problem hiding this comment.
The codebase uses explicit NULL checks instead of treating the pointer as a boolean. In addition mbedtls_x509_crt_free does not specify that x509_cert can be NULL, and so the function explicitly returns early.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.