Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Updated hard-coded CSS variables in index.html to match those in DNN 10 #1249

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Updated hard-coded CSS variables in index.html to match those in DNN 10 #1249

merged 1 commit into from
Jan 12, 2025

Conversation

david-poindexter
Copy link
Contributor

@david-poindexter david-poindexter commented Jan 12, 2025 •
edited
Loading

This PR handles the following:

  • Updated hard-coded CSS variables in index.html to match those in DNN 10.
  • Updated the body font size to properly handle the numeric value of --dnn-base-font-size.

Resolves #1248

@david-poindexter david-poindexter added the enhancement New feature or request label Jan 12, 2025
@david-poindexter david-poindexter added this to the 0.25.1 milestone Jan 12, 2025
@david-poindexter david-poindexter self-assigned this Jan 12, 2025
valadas
valadas approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks.

@valadas valadas merged commit 6ad4cc7 into DNNCommunity:develop Jan 12, 2025
2 checks passed
@david-poindexter david-poindexter deleted the dnn-css-vars-update branch January 12, 2025 18:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@valadas valadas valadas approved these changes

Assignees

@david-poindexter david-poindexter

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.25.1
Development

Successfully merging this pull request may close these issues.

Hard-coded CSS variables in index.html need to be updated to match DNN 10
2 participants
@david-poindexter @valadas