-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Csmobservation #4419
Csmobservation #4419
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,6 @@ find files of those names at the top level of this repository. **/ | |
#include "LinearAlgebra.h" | ||
|
||
namespace Isis { | ||
class BundleObservationSolveSettings; | ||
|
||
/** | ||
* @brief Class for bundle observations | ||
|
@@ -43,7 +42,7 @@ namespace Isis { | |
virtual AbstractBundleObservation &operator=(const AbstractBundleObservation &src); | ||
|
||
// copy method | ||
// not implementedn in BundleObservation either??? | ||
// not implementedn in BundleObservation either??? | ||
// virtual void copy(const AbstractBundleObservation &src); | ||
|
||
virtual void append(const BundleImageQsp &value); | ||
|
@@ -61,7 +60,7 @@ namespace Isis { | |
virtual LinearAlgebra::Vector &adjustedSigmas(); | ||
|
||
|
||
virtual const BundleObservationSolveSettingsQsp solveSettings() = 0; | ||
virtual const BundleObservationSolveSettingsQsp solveSettings() = 0; | ||
virtual int numberParameters(); | ||
virtual bool applyParameterCorrections(LinearAlgebra::Vector corrections); | ||
|
||
|
@@ -73,7 +72,7 @@ namespace Isis { | |
virtual QStringList parameterList(); | ||
virtual QStringList imageNames(); | ||
|
||
private: | ||
protected: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The members below here are duplicated in the BundleObservation class. They probably need to go away. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed. Making the values protected in the parent and removing from the child classes works as a solution and I merged this, but am still potentially interested in investigating if it's possible to handle weights/corrections/apriori/adjustedsigmas at the parent level if we were to modify how these are applied to be be more generalized. |
||
QString m_observationNumber; /**< This is typically equivalent to serial number | ||
except in the case of "observation mode" (e.g. | ||
Lunar Orbiter) where for each image in the | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that these are not exposed via the Camera API so we have to dynamic cast to get to them.