Fixed warning in Pixel unit tests #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlberry
reviewed
Dec 18, 2018
| @@ -465,7 +465,6 @@ TEST(Pixel, static_ToString) { | |||
| EXPECT_EQ(std::string("Lis"), Pixel::ToString(Isis::Lis)); | |||
| EXPECT_EQ(std::string("Lrs"), Pixel::ToString(Isis::Lrs)); | |||
| EXPECT_EQ(std::string("Null"), Pixel::ToString(Isis::Null)); | |||
| EXPECT_EQ(std::string("Invalid"), Pixel::ToString(-1.0e+1000)); | |||
There was a problem hiding this comment.
Is there any way we can test "Invalid" still without exceeding the valid range for doubles? Or is that what "Invalid" checks for?
There was a problem hiding this comment.
This is checking for values below valid minimum. The problem is, all of the double values below valid minimum are special pixels or NaN.
The only way this happens is a double overflow, which I think is such an extreme outlier it's not worth testing.
There was a problem hiding this comment.
👍 Sounds good to me, then!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pixel unit tests were generating a warning.
Description
There was a test using a number that doesn't fit in a double.
Related Issue
#613
Motivation and Context
Removes build warnings
How Has This Been Tested?
Pixel unit test has been re-built and passes with the change.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: