Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Navigate #25

Merged
merged 29 commits into from
Feb 4, 2022
Merged

Navigate #25

merged 29 commits into from
Feb 4, 2022

Conversation

dblodgett-usgs
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021 •
edited
Loading

Codecov Report

Merging #25 (74cf8f9) into master (3861fe7) will increase coverage by 0.83%.
The diff coverage is 99.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   90.30%   91.14%   +0.83%     
==========================================
  Files          11       11              
  Lines        1517     1536      +19     
==========================================
+ Hits         1370     1400      +30     
+ Misses        147      136      -11
Impacted Files Coverage Δ
R/refactor_nhdplus.R 100.00% <ø> (ø)
R/aggregate_network.R 98.06% <99.29%> (+4.26%) ⬆️
R/catchment_geometry.R 76.02% <100.00%> (ø)
R/collapse.R 97.63% <100.00%> (+<0.01%) ⬆️
R/reconcile.R 88.94% <100.00%> (+0.10%) ⬆️
R/hyRefactor.R 85.71% <0.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3861fe7...74cf8f9. Read the comment docs.

dblodgett-usgs and others added 17 commits December 14, 2021 09:00
@dblodgett-usgs dblodgett-usgs mentioned this pull request Feb 3, 2022
Open
mikejohnson51 and others added 4 commits February 3, 2022 17:35
@mikejohnson51
address review, changes class() to inherits(), suppressWarning on lib…
ee96977 
…rary(terra)
@dblodgett-usgs
add missing outlets upstream of outlets confluence
71b9a7b
@dblodgett-usgs
merge conflicts
4ad86cb 
Merge branch 'master' of github.com:mikejohnson51/hyRefactor into navigate

# Conflicts:
#	DESCRIPTION
#	NAMESPACE
#	R/aggregate_network.R
#	R/catchment_geometry.R
#	man/add_lengthmap.Rd
#	tests/testthat/test_erie_canal.R
@dblodgett-usgs
more generic unnest
81c267d
@dblodgett-usgs dblodgett-usgs mentioned this pull request Feb 4, 2022
Merged
@dblodgett-usgs dblodgett-usgs merged commit e669fcd into main Feb 4, 2022
@dblodgett-usgs dblodgett-usgs deleted the navigate branch February 4, 2022 18:29
@dblodgett-usgs dblodgett-usgs mentioned this pull request Feb 4, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dblodgett-usgs @codecov-commenter @mikejohnson51