refix #2279: get associated ContestProblem with Clarification entity #2607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0219d8e.
cubercsl
reviewed
Jun 17, 2024
|
Any update? Sorry for disturbing but I would like to request a review @vmcj |
vmcj
approved these changes
Jun 23, 2024
meisterT
approved these changes
Jun 23, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2279 indeed. In the previous commit 0219d8e, this issue was accidentally "fixed" by abusing
LEFT JOIN. Thanks to Doctrine's mapping & collection strategies, that commit works.This PR implements
getContestProblem(Problem $problem)in Contest entity by moving the codes inTwigExtension::problemBadgeForProblemAndContest, and adds a getter for the associated ContestProblem in Clarification entity. With these helpers, the key code of #2279 (clarification.problem.contestProblems.first) can be replaced withclarification.contestProblem.By the way, I renamed the twig filter
problemBadgeForProblemAndContesttoproblemBadgeForContest, as the Problem is redundant here.0219d8e is reverted in this PR, so the bug mentioned in #2600 no longer exists.