Skip to content

feat(all sql): add all sql expression column #358

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 7 commits into from
May 8, 2025

Conversation

LuckyFBB
Copy link
Collaborator

嵌套 columnName 在 expression 里面

但是有些地方使用了 expression 并不需要我们提示字段,因此我们需要判断当前 columnName 的路径是否在 groupBy 中

image

我们通过 core.collectCandidates 拿到的 candidates 就包含了当前的路径,在 ruleList 里面

  • Impala
    • select expression
    • group by expression
    • order by expression
    • partition by expression
    • having expression
    • join relation
    • case when
    • where expression
  • Trino
    • select expression
    • group by expression
    • order by expression
    • partition by expression
    • having expression
    • join relation
    • case when
    • where expression

@LuckyFBB LuckyFBB force-pushed the feat/expressionColumn branch from 7fb4c56 to 091d76d Compare October 16, 2024 02:07
@LuckyFBB LuckyFBB force-pushed the feat/expressionColumn branch 2 times, most recently from 3e250b2 to c2f525d Compare October 16, 2024 07:55
@LuckyFBB LuckyFBB force-pushed the feat/expressionColumn branch from c2f525d to 84c1008 Compare October 17, 2024 11:32
@LuckyFBB LuckyFBB changed the title feat(impala): add impala expression column feat(all sql): add impala expression column Oct 18, 2024
@LuckyFBB LuckyFBB changed the title feat(all sql): add impala expression column feat(all sql): add all sql expression column Oct 22, 2024
@mumiao
Copy link
Collaborator

mumiao commented Dec 18, 2024

  • rebase一下抵消一些变更
  • 解决一下冲突

@LuckyFBB LuckyFBB force-pushed the feat/expressionColumn branch from 427acb1 to c97ac12 Compare December 18, 2024 03:26
@LuckyFBB
Copy link
Collaborator Author

  • rebase一下抵消一些变更
  • 解决一下冲突

done

@mumiao
Copy link
Collaborator

mumiao commented Mar 28, 2025

有冲突

@mumiao
Copy link
Collaborator

mumiao commented May 8, 2025

冲突

@LuckyFBB LuckyFBB force-pushed the feat/expressionColumn branch from a7d5d34 to 42e689b Compare May 8, 2025 06:38
@LuckyFBB
Copy link
Collaborator Author

LuckyFBB commented May 8, 2025

冲突

done

@mumiao mumiao merged commit 26219b8 into DTStack:next May 8, 2025
6 checks passed
mumiao added a commit that referenced this pull request May 8, 2025
* feat: improve errorListener msg (#281)

* feat: add mysql errorListener and commonErrorListener

* feat: improve other sql error msg

* feat: support i18n for error msg

* feat: add all sql errorMsg unit test

* feat: update locale file and change i18n funtion name

* test: upate error unit test

* feat(flinksql): collect comment, type attribute for entity (#319)

* feat(flinksql): collect comment, type attribute for entity

* feat(flinksql): delete console log

* fix(#305): delete function ctxToWord,using ctxToText instead of ctxToWord

* feat: update attribute's type

* feat(flinksql): update flinksql's entitycollect unit test

* feat: optimize interface and update unit test

* feat: update collect attr detail

* feat: optimize interface and some function's arguments

* feat: add comment and update params' name

* feat: collect alias in select statement

* feat: update collect attribute function and update unit test

---------

Co-authored-by: zhaoge <>

* fix: spell check (#337)

Co-authored-by: liuyi <liuyi@dtstack.com>

* ci: check-types and test unit update

* feat: collect entity's attribute(#333)

* feat(trinosql): collect trino sql's attribute(comment,alias,colType)

* feat(hivesql): collect hive sql's attribute(comment,alias,colType)

* feat(impalasql): collect attribute(comment, colType, alias)

* feat(sparksql): collect entity's attribute (comment,alias, colType)

* feat: update endContextList of collect attribute

* feat(postgresql): collect hive sql's attribute(alias,colType)

* feat: update interface of attrInfo and alter entitycollect ts file

* feat(mysql): collect entity's attribute(comment,colType,alias)

* ci: fix check-types problem

---------

Co-authored-by: zhaoge <>

* chore(release): 4.1.0-beta.0

* fix: #362 set hiveVar value (#369)

* fix: #371 export EntityContext types (#372)

* fix: minimum collect candidates boundary to fix parse performance (#378)

* fix: minimum collect candidates boundary to fix parse performance

* fix: fix check-types

* fix: remove debugger code

* fix(flink): fix flinksql syntax error about ROW and function using (#383)

Co-authored-by: zhaoge <>

* build: pnpm antlr4 --lang all

* Feat/follow keywords (#407)

* feat: provide follow keywords when get suggestions

* chore: add watch script

* refactor: optimize spark grammar (#360)

* feat: support semantic context of isNewStatement (#361)

* feat: support semantic context of isStatamentBeginning

* docs: add docs for semantic context

* feat: unify variables in lexer (#366)

* feat: unify variables in lexer

* fix: all sql use WHITE_SPACE

* feat: complete after error syntax (#334)

* refactor: split getMinimumParserInfo to slice input and parser again

* test: complete after error syntax

* feat: complete after error syntax

* feat: use createParser to get parserIns and remove parserWithNewInput

* feat(all sql): add all sql expression column (#358)

* feat(impala): add impala expression column

* feat(trino): add expression column

* feat(hive): add hive expression column

* feat(spark): add spark expression column

* feat(mysql): add mysql expression column unit test

* feat(flink): add flink expression column

* feat(postgresql): add pg expression column

* feat: #410 optimize processCandidates tokenIndexOffset (#411)

* test: test suggestion wordRanges with range when processCandidates without tokenIndexOffset

* feat: #410 optimize processCandidates tokenIndexOffset

---------

Co-authored-by: 霜序 <976060700@qq.com>
Co-authored-by: XCynthia <942884029@qq.com>
Co-authored-by: 琉易 <liuxy0551@qq.com>
Co-authored-by: liuyi <liuyi@dtstack.com>
Co-authored-by: zhaoge <>
Co-authored-by: Hayden <hayden9653@gmail.com>
Co-authored-by: JackWang032 <64318393+JackWang032@users.noreply.github.com>
Co-authored-by: JackWang032 <2522134117@qq.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants