Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

An attempt to fix the dataclass usage in Python 3.11 #98

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

eflumerf
Copy link
Member

https://docs.python.org/3/library/dataclasses.html#mutable-default-values

Resolves #97

Tested to be backwards-compatible with current Python

@eflumerf
Copy link
Member Author

This was tested using both NFD_DEV_250114_A9 and NFDT_DEV_250113_A9.

@jcfreeman2
Copy link
Contributor

I've confirmed that this simple change, using the default factory function to create an instance of the dro_map_config rather than using a shared instance, fixes the error.

@jcfreeman2 jcfreeman2 merged commit 9685334 into develop Jan 14, 2025
1 check passed
@jcfreeman2 jcfreeman2 deleted the eflumerf/MutableDataclassMember branch January 14, 2025 15:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integrationtest not compatible with newer version (3.11.7) of Python
2 participants