-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add icons for each version control service #10
Comments
Hello, I tried to create a pull request to fix this issue, but I am not able to create a pull request from my commit. Until i will figure it out here is my text for pull request: Add icons for each version control service #10 Version control service icons added to:
Visible on the screenshots below. GitHub icon was not standing out in dark mode so I added black and also white icon. Light mode uses black and dark mode uses white icon. I added also Bitbucket option for the future, it is commented for now. All the icons are from official assets(company websites), sized down to 18x18.png files. I don’t know how to resize NSImage, so after some time I resized the icons. If there is some simple solution I will be very happy to learn about it.
I also added serviceType to PipelineResult, so I can load icon according to type for widget pipelines. I hope that this changes will be useful. BR, |
Hi 👋 Great job 👍I like white & black logo detail 🙂I can see png icons in Assets.xcaassets folder which I fine. Also i think you committed some of yours user data |
Thank you 🙂 should i remove the file? Or it is okay and i can leave it there? |
Each version control service has its logo. Logo is displayed in configuration and pipeline list next to repository name.
Depends on #6
The text was updated successfully, but these errors were encountered: