Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Doctrine DHMiddleware by default #331

Merged
merged 8 commits into from
Nov 14, 2022

Conversation

dmitryuk
Copy link
Contributor

@dmitryuk dmitryuk commented Nov 11, 2022

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #331 (873cfc8) into master (9ad2367) will decrease coverage by 0.52%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   93.22%   92.69%   -0.53%     
==========================================
  Files          15       15              
  Lines         295      315      +20     
==========================================
+ Hits          275      292      +17     
- Misses         20       23       +3     
Impacted Files Coverage Δ
...iler/DoctrineProviderConfigurationCompilerPass.php 89.13% <85.00%> (-3.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dmitryuk
Copy link
Contributor Author

@DamienHarper I need a new release of https://github.com/DamienHarper/auditor to make test work

@DamienHarper
Copy link
Owner

DamienHarper commented Nov 11, 2022

@dmitryuk auditor 2.2.0 is released

@dmitryuk
Copy link
Contributor Author

dmitryuk commented Nov 14, 2022

Tests anyway will throw User Deprecated: The "Symfony\Bridge\Doctrine\Logger\DbalLogger" class implements "Doctrine\DBAL\Logging\SQLLogger" that is deprecated Use {@see \Doctrine\DBAL\Logging\Middleware} or implement {@see \Doctrine\DBAL\Driver\Middleware} instead. because Doctrine anyway defines the doctrine.dbal.logger service and Symfony includes the class to dump container.

But now the error not caused by auditor package and must be resolved outside the package.

image
image

PR is ready for review and merge

@dmitryuk dmitryuk changed the title Draft:Add Doctrine DHMiddleware by default Add Doctrine DHMiddleware by default Nov 14, 2022
@DamienHarper
Copy link
Owner

@dmitryuk Thanks a lot for your hard work

@DamienHarper DamienHarper merged commit f5c3fa3 into DamienHarper:master Nov 14, 2022
@dmitryuk
Copy link
Contributor Author

@DamienHarper can you make a release?

@DamienHarper
Copy link
Owner

@dmitryuk done

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation of Doctrine\DBAL\Logging\SQLLogger Interface
2 participants