Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

#345 Deprecation in RoleChecker and UserProvider #350

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

dmitryuk
Copy link
Contributor

Closes #345

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #350 (4673868) into 5.x (3da0a92) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              5.x     #350   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files          15       15           
  Lines         353      353           
=======================================
  Hits          330      330           
  Misses         23       23           
Impacted Files Coverage Δ
src/Security/RoleChecker.php 89.47% <100.00%> (ø)
src/User/UserProvider.php 92.68% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Owner

@DamienHarper DamienHarper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmitryuk!

@DamienHarper DamienHarper merged commit 868e26b into DamienHarper:5.x Feb 27, 2023
DamienHarper pushed a commit that referenced this pull request Mar 2, 2023
---------

Co-authored-by: a.dmitryuk <a.dmitryuk@movavi.com>
DamienHarper added a commit that referenced this pull request Jul 14, 2024
* Updated CI

* Fixed middlewares override (#341)

* Revert unwanted PHP >= 8.0 changes

* Updated branch alias

* Reverted and adjusted middleware test

* Adjusted middleware registration priority (fixed failing tests)

* Fixed unwanted deps changes

* Fixed failing test

* #345 Deprecation in RoleChecker and UserProvider (#350)

* #345 Deprecation in RoleChecker and UserProvider

* remove line

---------

Co-authored-by: a.dmitryuk <a.dmitryuk@movavi.com>

* Fixed CI (PHPStan)

* Support doctrine/annotations:2.0 (#351)

* remove doctrine/annotations from composer.json

* doctrine/annotations 2.0

---------

Co-authored-by: a.dmitryuk <a.dmitryuk@movavi.com>

* Fixed compatibility with Symfony 4.4

* PHP-CS-Fixer

* Fixed CI (#367)

* PHP-CS-Fixer

* Fix: `ViewerController` (#379)

* Fix: `ViewerController`

* -

* -

* -

* Fixed remaining calls to AbstractController methods.

* -

* -

* -

* -

* PHP-CS-Fixer

---------

Co-authored-by: Damien Harper <damien.harper@gmail.com>

* CI updates

* Make `ViewerController` final (#385)

Co-authored-by: Damien Harper <damien.harper@gmail.com>

* Test more PHP versions (#389)

Co-authored-by: Damien Harper <damien.harper@gmail.com>

* Use `actions/checkout@v4` (#387)

Co-authored-by: Damien Harper <damien.harper@gmail.com>

* PHP-CS-Fixer

* Update deps + PHP-CS-Fixer

* PHP-CS-Fixer (3.48.0)

* 6.x

Signed-off-by: Oleg Andreyev <oleg@andreyev.lv>

* reverted ci-5.x.yml

Signed-off-by: Oleg Andreyev <oleg@andreyev.lv>

* reverted ci-5.x.yml

Signed-off-by: Oleg Andreyev <oleg@andreyev.lv>

* clean composer.json

Signed-off-by: Oleg Andreyev <oleg@andreyev.lv>

* reverted ci-4.x.yml

Signed-off-by: Oleg Andreyev <oleg@andreyev.lv>

* damienharper/auditor dev-master

Signed-off-by: Oleg Andreyev <oleg@andreyev.lv>

* allow ^3.1 orm

Signed-off-by: Oleg Andreyev <oleg@andreyev.lv>

---------

Signed-off-by: Oleg Andreyev <oleg@andreyev.lv>
Co-authored-by: Damien Harper <damien.harper@gmail.com>
Co-authored-by: Alexander Dmitryuk <xakzona@bk.ru>
Co-authored-by: a.dmitryuk <a.dmitryuk@movavi.com>
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants