Fix heap buffer overflow in selReadStream (detected by clang address sanitizer) #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix for tiffio breaks |
stweil
changed the title
stweil
commented
May 3, 2020
stweil
commented
May 3, 2020
| @@ -1431,17 +1431,14 @@ SEL *sel; | |||
|
|
|||
| if (fgets(linebuf, sizeof(linebuf), fp) == NULL) | |||
| return (SEL *)ERROR_PTR("error reading into linebuf", procName, NULL); | |||
| selname = stringNew(linebuf); | |||
| sscanf(linebuf, " ------ %200s ------", selname); | |||
There was a problem hiding this comment.
... and here 201 bytes were written to selname.
stweil
changed the title
|
I found and fixed the int32 --> uint32 issue before reading your PR. Thank you for this, and for fixing the selname issue. Seems I can't merge because of a build issue |
|
The build issue on Ubuntu looks unrelated to this pull request. @egorpugin, can you help, please? |
|
Ignore it. Error is unrelated to leptonica. It's on sw side, I'll check. |
|
Should be ok now. |
selio_reg triggers a heap buffer overflow when sscanf tries to write 201 bytes into a 24 byte string.
It can be detected when the code is compiled with the address sanitizer:
==19856==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x603000001288 at pc 0x00000044462b bp 0x7fffffffddf0 sp 0x7fffffffd5a0
WRITE of size 201 at 0x603000001288 thread T0
0x603000001288 is located 0 bytes to the right of 24-byte region [0x603000001270,0x603000001288)
Signed-off-by: Stefan Weil <sw@weilnetz.de>
|
I just realized this was waiting. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.