Refactor function parsing and enhance test validations. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change restores the `parse_components_to_file` method to ensure components can be parsed and written into a file. The method was previously removed but is necessary for generating KFP component files correctly. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Refactored function scope generation to handle empty cases more cleanly. Updated test cases to validate the number of initializer parameters and function parameters explicitly. Added missing meta components to valid_classes_meta and valid_classes_meta_v2 lists. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Removed redundant mypy overrides for tests in `pyproject.toml` and adjusted the `mypy` target in the Makefile to run checks specifically on the `ml_orchestrator` module. Also added a missing type ignore comment in `t_suites.py` for consistent type checking behavior. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 98.93% 98.94% +0.01%
==========================================
Files 11 11
Lines 281 285 +4
==========================================
+ Hits 278 282 +4
Misses 3 3 ☔ View full report in Codecov by Sentry. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.