-
-
Notifications
You must be signed in to change notification settings - Fork 242
Closed
Description
Line 259 in c1d6146
$<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wall -Wextra -pedantic> # Other compilers |
Setting warning levels like those assumes that users are using the same compilers (and same versions thereof) as you are in your testing, and punishes users with spammy build logs if they're using newer compiler versions (which often come with new warnings!).
Ideally, warning levels for development purposes should instead be set in CI by setting the appropriate CXXFLAGS
(probably along with -Werror
) or locally by using appropriate tools like the new CMakePresets.json
or equivalent.