Skip to content

Converted unix line endings to windows #101

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

jzapdot
Copy link
Contributor

@jzapdot jzapdot commented Dec 4, 2019

Summary

This PR converts all line endings in the SOArchitecturePreferences.cs file from Unix/Linux (LF) to Windows (CRLF). Previously this had mixed line endings which caused a warning in the Unity Editor console. There are not any functional changes associated with this PR.

Example of warning

There are inconsistent line endings in the 'Packages/com.danieleverland.scriptableobjectarchitecture/SOArchitecturePreferences.cs' script. Some are Mac OS X (UNIX) and some are Windows.
This might lead to incorrect line numbers in stacktraces and compiler errors. Many text editors can fix this using Convert Line Endings menu commands.

Testing

The easiest way to test this is by opening the project and verifying that there are not any warnings in the console about mixed line endings. If you wanted to go the extra mile you could make a new release from this branch's contents and very when imported into a new project that the same warnings do not appear.

* Converted unix line endings to windows for SOArchitecturePreferences.cs
@DanielEverland
Copy link
Owner

In the middle of some exams, which finish the 17th, so I might not get to this as quickly as usual. Feel free to ping me after the 17th if I forget :)

@DanielEverland DanielEverland merged commit 732ac02 into DanielEverland:master Dec 26, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants