Fixed a bug with CollectionEditor #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed the implementation for the onRemoveCallback used by the ReorderableList in the CollectionEditor; this keeps the intended behavior (as default) for removing the item, but prevents an exception that a user would experience by removing an item this way.
jeffcampbellmakesgames
force-pushed
the
fix/collection_editor_list_exception
branch
from
c0c7295 to
83893d3
Compare
PauloHMattos
pushed a commit
to PauloHMattos/ScriptableObject-Architecture
that referenced
this pull request
Aug 3, 2019
…collection_editor_list_exception Fixed a bug with CollectionEditor
jeffcampbellmakesgames
deleted the
fix/collection_editor_list_exception
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug with the collection editor where the implementation for the
onRemoveCallbackof theReorderableListbeing used would result in an exception every time a user tried to remove an item. The fix actually removes both the implementation and use of the callback as the default implementation internal toReorderableListwill have the same net result as the implementation was trying to do.Testing
Attempt to add and remove entries from any Collection asset. Prior to this fix you would see the exception thrown above and the item would not be shown as removed in the inspector. With this fix you should see the item removed in the inspector without any error.
Changes
Fixed a bug with CollectionEditor