Turn private library into common stanza #96
Conversation
| import: build-deps, extensions | ||
| exposed-modules: | ||
| other-modules: |
There was a problem hiding this comment.
Otherwise we would expose these modules everywhere, did I get this right?
There was a problem hiding this comment.
The exposed-modules: Symlink below should also be other-modules.
| import: build-deps, extensions | ||
| exposed-modules: | ||
| other-modules: |
Private libraries have a bunch of bugs in cabal currently: * haskell/cabal#6211 * haskell/cabal#6483 and devs of haskell-ide-engine are encountering this bug frequently. To mitigate this issue, remove usage of private libraries and use a common stanza to have the same re-use as before. This change can be undone when the mentioned issues have been resolved.
fendor
force-pushed
the
common-stanza-over-private-lib
branch
from
78ea5b3 to
3f58f52
Compare
cabal-helper.cabal
Outdated
| @@ -186,7 +183,6 @@ test-suite ghc-session | |||
| build-depends: ghc < 8.9 && >= 8.0.2 | |||
| , pretty-show < 1.9 && >= 1.8.1 | |||
| , cabal-helper | |||
There was a problem hiding this comment.
this works with cabal build --enable-tests? i was giving a try and it failed for me in ghc-session with:
tests\GhcSession.hs:71:31: error:
• Couldn't match expected type ‘CabalHelper.Compiletime.Types.Programs’
with actual type ‘Programs’
NB: ‘Programs’
is defined in ‘CabalHelper.Compiletime.Types’
in package ‘cabal-helper-1.0.0.0’
‘CabalHelper.Compiletime.Types.Programs’
is defined in ‘CabalHelper.Compiletime.Types’
• In the first argument of ‘modProgs’, namely ‘defaultPrograms’
In the expression: modProgs defaultPrograms
In the expression:
let
?verbose = const False
?progs = modProgs defaultPrograms
in action
|
71 | ?progs = modProgs defaultPrograms
|
So i was about to remove cabal-helperfrom build-depends and add the public lib modules as src ones
There was a problem hiding this comment.
Didnt test, sorry, will do immediately
There was a problem hiding this comment.
This seems non-trivial as this depends on both the internal common stanza and cabal-helper. they need to depend on the same common-stanza, which cabal doesnt seem to be able to prove (which sounds like the exact reason for private libraries).
There was a problem hiding this comment.
So i was about to remove cabal-helper from build-depends and add the public lib modules as src ones
Have you tried this?
There was a problem hiding this comment.
Yeah looks you'll have to the main cabal-helper library into a stanza too :/
| import: build-deps, extensions | ||
| exposed-modules: | ||
| other-modules: |
There was a problem hiding this comment.
The exposed-modules: Symlink below should also be other-modules.
cabal-helper.cabal
Outdated
| @@ -186,7 +183,6 @@ test-suite ghc-session | |||
| build-depends: ghc < 8.9 && >= 8.0.2 | |||
| , pretty-show < 1.9 && >= 1.8.1 | |||
| , cabal-helper | |||
There was a problem hiding this comment.
Yeah looks you'll have to the main cabal-helper library into a stanza too :/
|
I got it building over in #97 just had to make the main lib a common section too. I'm pretty all this will blow up the build times by like x5 but let's see what CI says :) |
Private libraries have a bunch of bugs in cabal currently:
and devs of haskell-ide-engine are encountering this bug frequently.
To mitigate this issue, remove usage of private libraries and use
a common stanza to have the same re-use as before.
This change can be undone when the mentioned issues have been resolved.
closes #94
cc @jneira