Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Provide a copy of ESM-only files #7

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

IvanSanchez
Copy link
Contributor

I'm working on adding GeoTIFF support to Gleo (https://ivansanchez.gitlab.io/gleo/), and I'm doing so by using native ESM modules in the browser via importmap, eschewing any and all bundling (rollup/webpack/parcel/etc). As a consequence of all that, I'm hitting a variant of geotiffjs/geotiff.js#411 - the untouched JS code is reaching the browser, the browser tries to run require(), and crashes.

This PR provides ESM modules for all of xml-utils, as opposed to an ESM entry point but CJS files otherwise.

Fixes #5 BTW.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@DanielJDufour
Copy link
Owner

Reviewing now. Thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add esm compatibility
2 participants