Fix fortran char array #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses problems with Fortran character arrays passed to Python. The first was that the length of the character string was too short (20). The second was that only 1D arrays were managed and if the length of the character string is equal to the limit then the values in the array are not splited correctly. The max length has been increased from 20 to 128 and the associated decorator to handle character arrays has been modified to managed any nD arrays and max character length. A few tests have been added, but they don't allow you to check all the decorators correctly. It would be necessary to create a Fortran file specific to the test case.
Can't unpack tuple indices directly in arrays
asjeb
reviewed
Jun 11, 2024
| setup.descriptor_name = descriptor_name | ||
| assert np.array_equal(setup.descriptor_name, descriptor_name), "char_array.ndarray_nd_value" | ||
|
|
||
| with pytest.raises(ValueError, match="could not broadcast"): |
There was a problem hiding this comment.
When a ValueError could happen ?
There was a problem hiding this comment.
When a ValueError could happen ?
>>> setup, mesh = smash.factory.load_dataset('cance')
>>> model = smash.Model(setup, mesh)
>>> model.setup.nd
2
>>> model.setup.descriptor_name = ["Riri", "Fifi", "Loulou"]
ValueError: could not broadcast input array from shape (3,) into (2,)
asjeb
approved these changes
Jun 11, 2024
asjeb
reviewed
Jun 11, 2024
I will ! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses problems with Fortran character arrays passed to Python. The first was that the length of the character string was too short (20). The second was that only 1D arrays were managed and if the length of the character string is equal to the limit then the values in the array are not split correctly.
The max length has been increased from 20 to 128 and the associated decorator to handle character arrays has been modified to managed any nD arrays and max character length.
A few tests have been added, but they don't allow you to check all the decorators correctly. It would be necessary to create a Fortran file specific to the test case.