Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rebase of MJA pull request on main #241

Merged

Conversation

inoelloc
Copy link
Contributor

@maximejay
Petite galère qd j'ai voulu changer de branch pour merge ta pull request. Je me suis permis de reprendre tes commits directement depuis main. Tu me dis si c'est ok

@maximejay
Copy link
Collaborator

Salut,
Ca me parait bon !
Merci

Copy link
Collaborator

@maximejay maximejay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ca me parait tout bon !

@inoelloc inoelloc merged commit adac4ef into DassHydro:main Jul 11, 2024
11 checks passed
@inoelloc inoelloc deleted the rebase-feasible-domain-setup-boolean branch July 11, 2024 14:48
inoelloc added a commit to inoelloc/smash that referenced this pull request Jul 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request maintenance Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Allow integer 0 or 1 for model setup boolean FIX: Feasible domain for parameters
2 participants