Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ENH: set parameters condition outside active cell #288

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

inoelloc
Copy link
Contributor

Backport of #287

  • ENH: Mask active cell when checking if parameter is inside feasible domain
  • Allow to pass any value to a non active cell and it does not return an error.
  • Ruff and fprettify formatting applied
  • Remove unused constant TOL_BOUNDS since F_PRECISION is now used
  • FIX: Add F_PRECISION to serr parameters

Missing F_PRECISION for structural error parameters

  • FIX PR: Clean model standardize

* ENH: Mask active cell when checking if parameter is inside feasible domain

- Allow to pass any value to a non active cell and it does not return an error.
- Ruff and fprettify formatting applied
- Remove unused constant TOL_BOUNDS since F_PRECISION is now used

* FIX: Add F_PRECISION to serr parameters

Missing F_PRECISION for structural error parameters

* FIX PR: Clean model standardize
@inoelloc inoelloc added the backport Back porting label Jul 29, 2024
@inoelloc inoelloc added this to the Release v1.0.2 milestone Jul 29, 2024
@inoelloc inoelloc requested a review from nghi-truyen July 29, 2024 14:53
@inoelloc inoelloc merged commit 1a81374 into DassHydro:maintenance/1.0.x Jul 29, 2024
11 checks passed
@inoelloc inoelloc deleted the backport-287 branch July 29, 2024 15:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport Back porting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Handle active cell when setting rr_parameters or rr_initial_states
2 participants