Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a .generated_files #274

Merged
merged 5 commits into from
May 7, 2020
Merged

Add a .generated_files #274

merged 5 commits into from
May 7, 2020

Conversation

nmuesch
Copy link
Contributor

@nmuesch nmuesch commented May 1, 2020

What does this PR do?

This PR adds a .generated_files file at the root of the project to utilize the apigentools feature of deleting known generated files between generation runs - https://apigentools.readthedocs.io/en/latest/special_files/

Review checklist

Please check relevant items below:

  • This PR includes all newly recorded cassettes for any modified tests.

  • This PR does not rely on API client schema changes.

    • The CI should be fully passing.
  • Or, this PR relies on API schema changes and this is a Draft PR that includes tests.

    • Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

@nmuesch nmuesch requested a review from a team as a code owner May 1, 2020 17:04
@nmuesch
Copy link
Contributor Author

nmuesch commented May 1, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

.generated_files Outdated
Comment on lines 1 to 2
api_docs/*
src/main/java/com/datadog/api/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it glob or regex?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmuesch
Copy link
Contributor Author

nmuesch commented May 1, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #274 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted Files Coverage Δ Complexity Δ
...om/datadog/api/v1/client/model/MonitorOptions.java 38.30% <0.00%> (-1.59%) 42.00% <0.00%> (ø%)
...1/client/model/MonitorSummaryWidgetDefinition.java 62.50% <0.00%> (-1.23%) 34.00% <0.00%> (-6.00%)
...a/com/datadog/api/v1/client/model/MonitorType.java 84.21% <0.00%> (-0.79%) 5.00% <0.00%> (ø%)
...api/v1/client/model/LogStreamWidgetDefinition.java 60.95% <0.00%> (-0.66%) 37.00% <0.00%> (-3.00%)
...main/java/com/datadog/api/v1/client/ApiClient.java 51.11% <0.00%> (-0.36%) 58.00% <0.00%> (ø%)
...ain/java/com/datadog/api/v2/client/model/Role.java 25.64% <0.00%> (ø) 6.00% <0.00%> (ø%)
...va/com/datadog/api/v2/client/model/Permission.java 21.87% <0.00%> (ø) 4.00% <0.00%> (ø%)
.../com/datadog/api/v2/client/model/Organization.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...com/datadog/api/v1/client/model/LogsURLParser.java 46.77% <0.00%> (ø) 16.00% <0.00%> (ø%)
...om/datadog/api/v1/client/model/LogsGrokParser.java 51.66% <0.00%> (ø) 17.00% <0.00%> (ø%)
... and 22 more

@nmuesch
Copy link
Contributor Author

nmuesch commented May 7, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nmuesch
Copy link
Contributor Author

nmuesch commented May 7, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nmuesch nmuesch merged commit eb708ae into master May 7, 2020
@nmuesch nmuesch deleted the nick/generated_files branch May 7, 2020 19:19
@nmuesch nmuesch added changelog/Added Added features results into a minor version bump dev/tooling Tooling related changes labels May 20, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog/Added Added features results into a minor version bump dev/tooling Tooling related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants