Skip to content

dan.chiniara/url-encoding-for-monitor-api #2249

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.6",
"regenerated": "2025-03-17 17:20:20.728873",
"spec_repo_commit": "29344bf2"
"regenerated": "2025-03-17 21:06:24.773354",
"spec_repo_commit": "2dfddc18"
},
"v2": {
"apigentools_version": "1.6.6",
"regenerated": "2025-03-17 17:20:20.745019",
"spec_repo_commit": "29344bf2"
"regenerated": "2025-03-17 21:06:24.789125",
"spec_repo_commit": "2dfddc18"
}
}
}
12 changes: 9 additions & 3 deletions .generator/schemas/v1/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29328,7 +29328,7 @@ paths:
- description: 'When specified, shows additional information about the group
states.

Choose one or more from `all`, `alert`, `warn`, and `no data` (`no%20data`).'
Choose one or more from `all`, `alert`, `warn`, and `no data`.'
in: query
name: group_states
required: false
Expand Down Expand Up @@ -36863,7 +36863,10 @@ tags:

scopes from alerting. Downtime settings, which can be scheduled with start and

end times, prevent all alerting related to specified Datadog tags.'
end times, prevent all alerting related to specified Datadog tags.


**Note:** `curl` commands require [url encoding](https://curl.se/docs/url-syntax.html).'
name: Downtimes
- description: 'The Event Management API allows you to programmatically post events
to the Events Explorer and fetch events from the Events Explorer. See the [Event
Expand Down Expand Up @@ -36940,7 +36943,10 @@ tags:
notifies your team when a defined threshold has exceeded.


For more information, see [Creating Monitors](https://docs.datadoghq.com/monitors/create/types/).'
For more information, see [Creating Monitors](https://docs.datadoghq.com/monitors/create/types/).


**Note:** `curl` commands require [url encoding](https://curl.se/docs/url-syntax.html).'
externalDocs:
description: Find out more at
url: https://docs.datadoghq.com/monitors/create/types/
Expand Down
3 changes: 2 additions & 1 deletion features/v1/downtimes.feature
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ Feature: Downtimes
you greater control over monitor notifications by allowing you to globally
exclude scopes from alerting. Downtime settings, which can be scheduled
with start and end times, prevent all alerting related to specified
Datadog tags.
Datadog tags. **Note:** `curl` commands require [url
encoding](https://curl.se/docs/url-syntax.html).

Background:
Given a valid "apiKeyAuth" key in the system
Expand Down
4 changes: 3 additions & 1 deletion features/v1/monitors.feature
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ Feature: Monitors
[Monitors](https://docs.datadoghq.com/monitors) allow you to watch a
metric or check that you care about and notifies your team when a defined
threshold has exceeded. For more information, see [Creating
Monitors](https://docs.datadoghq.com/monitors/create/types/).
Monitors](https://docs.datadoghq.com/monitors/create/types/). **Note:**
`curl` commands require [url encoding](https://curl.se/docs/url-
syntax.html).

Background:
Given a valid "apiKeyAuth" key in the system
Expand Down
2 changes: 1 addition & 1 deletion lib/datadog_api_client/v1/api/monitors_api.rb
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ def list_monitors(opts = {})
# Get all monitors from your organization.
#
# @param opts [Hash] the optional parameters
# @option opts [String] :group_states When specified, shows additional information about the group states. Choose one or more from `all`, `alert`, `warn`, and `no data` (`no%20data`).
# @option opts [String] :group_states When specified, shows additional information about the group states. Choose one or more from `all`, `alert`, `warn`, and `no data`.
# @option opts [String] :name A string to filter monitors by name.
# @option opts [String] :tags A comma separated list indicating what tags, if any, should be used to filter the list of monitors by scope. For example, `host:host0`.
# @option opts [String] :monitor_tags A comma separated list indicating what service and/or custom tags, if any, should be used to filter the list of monitors. Tags created in the Datadog UI automatically have the service key prepended. For example, `service:my-app`.
Expand Down
Loading