-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add retry support #1293
Add retry support #1293
Conversation
…ent-typescript into hzhang/add-retry
…ent-typescript into hzhang/add-retry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment otherwise looks good. Wondering maybe if we should remove the recursive call and use a loop like everywhere else? It seems different for no particular reason.
TS does not support jump target cross function boundary which made using loop harder at the beginning. |
* add configs * Implement retry and refactor fetch * retry test + sleep mock * pre-commit fixes * Test sleep time * Revert "Merge branch 'hzhang/add-retry' of github.com:DataDog/datadog-api-client-typescript into hzhang/add-retry" This reverts commit 61c0f17, reversing changes made to 11fc11f. * add test for backoffbase validation * change generator * pre-commit fixes * AddPropertyBack * pre-commit fixes * add params to constructor * Add nock to license * add backoff base validation * Update Readme * changes * pre-commit fixes * refactor execute request * pre-commit fixes * add () * pre-commit fixes * simplifie * pre-commit fixes --------- Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> 9b22d7d
What does this PR do?
Adds retry support for the api client
Additional Notes
Review checklist
Please check relevant items below:
This PR includes all newly recorded cassettes for any modified tests.
This PR does not rely on API client schema changes.
Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.