Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Validate BDD models in tests #904

Merged
merged 46 commits into from
Dec 19, 2022
Merged

Validate BDD models in tests #904

merged 46 commits into from
Dec 19, 2022

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Nov 9, 2022 •
edited
Loading

This PR adds support for validating models in the bdd tests instead of renaming keys as we did previously. This fixes few additional things as well:

  • Fix serialization and deserialization of additional properties
  • UnparsedObject key renamed to _data
  • Fix serialization and deserialization of Date objects
  • Fix serialization and deserialization of unparsedObjects
  • change unparsedObject: any attr to _unparsed: bool

skarimo added 21 commits October 19, 2022 10:56
@skarimo
convert params to models in bdd tests
c3e525f
@skarimo
fix deserializing
2e05024
@skarimo
serialize response for comparing
52225e0
@skarimo
additionalProperties in deserialization
e4c7bb4
@skarimo
target es6
89df688
@skarimo
add RFC3339 serialization/deserialization support
0225266
@skarimo
generate model mappings for all endpoints
91acd0b
@skarimo
fix padded nsec and pagination deserialization
45aa09c
@skarimo
fix enum deserialization
0d17caf
@skarimo
refactor additionalProperties
4111588
@skarimo
rename unparsedObject property
e9a3106
@skarimo
fix deserialization of additionalProperties
7515626
@skarimo
cleanup serializer and undo previous changes
b63954f
@skarimo
fix UnparsedObject import
4defa31
@skarimo
better handle unparsedObjects
ee76ba8
@skarimo
re-introduce containsUnparsed helper
1699b81
@skarimo
Merge branch 'master' into sherz/validate-bdd-models
3972c7d
@skarimo
regen master
322a3c0
@skarimo
Merge branch 'master' into sherz/validate-bdd-models
377496b
@skarimo
regenerate
ee3f75e
@skarimo
handle bigger msec
4084e90
@skarimo skarimo requested a review from a team as a code owner November 9, 2022 20:20
therve
therve requested changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@therve therve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized we didn't run the deserialization tests in CI. They are broken in master, but this PR makes things a bit worse, can you check it out? Also fix run-tests.sh to run them.

skarimo and others added 20 commits December 8, 2022 13:40
@skarimo skarimo merged commit 8903e20 into master Dec 19, 2022
@skarimo skarimo deleted the sherz/validate-bdd-models branch December 19, 2022 15:11
github-actions bot pushed a commit that referenced this pull request Dec 19, 2022
@skarimo
Validate BDD models in tests (#904)
54946ea 
* convert params to models in bdd tests

Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com>
Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> 8903e20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@therve therve therve approved these changes

Assignees
No one assigned
Labels
changelog/Changed changelog/Fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skarimo @therve