Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

RUM-7691: Add addAttributes and removeAttributes APIs #2177

Conversation

simaoseica-dd
Copy link
Contributor

@simaoseica-dd simaoseica-dd commented Jan 22, 2025

What and why?

This PR introduces a new interface to add and remove multiple attributes simultaneously.
This enhancement reduces threading pressure on the Message Bus when handling multiple attributes at once.

How?

The new interfaces to handle multiple attributes are:

func addAttributes(_ attributes: [AttributeKey: AttributeValue])

func removeAttributes(forKeys keys: [AttributeKey])

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines [internal]) and run make api-surface)

@simaoseica-dd simaoseica-dd requested review from a team as code owners January 22, 2025 11:56
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good direction and nice work on integration tests 👌🚀. I left a blocking feedback on the performance of attributes removal.

@simaoseica-dd simaoseica-dd force-pushed the simaoseica/RUM-7691/add-addattributes-and-removeattributes-apis branch from 6aa6749 to 50e84c9 Compare January 23, 2025 14:00
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 23, 2025

Datadog Report

Branch report: simaoseica/RUM-7691/add-addattributes-and-removeattributes-apis
Commit report: d1fa8ca
Test service: dd-sdk-ios

✅ 0 Failed, 1705 Passed, 2058 Skipped, 1m 47s Total duration (50.77s time saved)

@simaoseica-dd simaoseica-dd force-pushed the simaoseica/RUM-7691/add-addattributes-and-removeattributes-apis branch from 50e84c9 to f9192b8 Compare January 23, 2025 15:42
@simaoseica-dd simaoseica-dd force-pushed the simaoseica/RUM-7691/add-addattributes-and-removeattributes-apis branch 2 times, most recently from 39e085d to 29cc793 Compare January 24, 2025 17:52
ncreated
ncreated previously approved these changes Jan 27, 2025
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! I appreciate the effort on adding coverage in Monitor+GlobalAttributes 🙂🏅.

maxep
maxep previously approved these changes Jan 27, 2025
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, I've left a couple of minor suggestions 👍

@simaoseica-dd simaoseica-dd dismissed stale reviews from maxep and ncreated via d1fa8ca January 27, 2025 14:28
@simaoseica-dd simaoseica-dd force-pushed the simaoseica/RUM-7691/add-addattributes-and-removeattributes-apis branch from b7e5f7b to d1fa8ca Compare January 27, 2025 14:28
@simaoseica-dd simaoseica-dd merged commit 23d2fcf into develop Jan 28, 2025
14 checks passed
@maxep maxep mentioned this pull request Feb 5, 2025
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants