-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
RUM-7691: Add addAttributes
and removeAttributes
APIs
#2177
RUM-7691: Add addAttributes
and removeAttributes
APIs
#2177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good direction and nice work on integration tests 👌🚀. I left a blocking feedback on the performance of attributes removal.
6aa6749
to
50e84c9
Compare
Datadog ReportBranch report: ✅ 0 Failed, 1705 Passed, 2058 Skipped, 1m 47s Total duration (50.77s time saved) |
50e84c9
to
f9192b8
Compare
39e085d
to
29cc793
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! I appreciate the effort on adding coverage in Monitor+GlobalAttributes
🙂🏅.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, I've left a couple of minor suggestions 👍
b7e5f7b
to
d1fa8ca
Compare
What and why?
This PR introduces a new interface to add and remove multiple attributes simultaneously.
This enhancement reduces threading pressure on the Message Bus when handling multiple attributes at once.
How?
The new interfaces to handle multiple attributes are:
Review checklist
make api-surface
)