contrib/confluentinc/confluent-kafka-go: fix goroutine leak in Produce #2924
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Thanks to @majorgreys who reported this issue).
Fix a goroutine leak in
producer.Produce
when the actual Produce call was returning an error and adeliveryChan
is provided.In this case, the goroutine "wrapping" the original channel gets stuck waiting for a message in the channel, but no event is ever sent to that channel.
Motivation
Fix goroutine leak.
Reviewer's Checklist
Unsure? Have a question? Request a review!