Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

mcache check supports IPv6 address #19359

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

keisku
Copy link
Contributor

@keisku keisku commented Jan 9, 2025

What does this PR do?

mcache check supports IPv6 address.

Motivation

Now python-binary-memcached supports IPv6.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@@ -36,7 +36,7 @@ dynamic = [

[project.optional-dependencies]
deps = [
"python-binary-memcached==0.31.2; sys_platform != 'win32'",
"python-binary-memcached==0.31.4; sys_platform != 'win32'",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch version includes jaysonsantos/python-binary-memcached#258

@keisku keisku force-pushed the keisku/mcache-check-ipv6-support branch 2 times, most recently from 3aa3d1e to 6792281 Compare January 9, 2025 00:59
Signed-off-by: keisku <keisuke.umegaki@datadoghq.com>
@keisku keisku force-pushed the keisku/mcache-check-ipv6-support branch from 6792281 to bbc2b06 Compare January 9, 2025 00:59
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.88%. Comparing base (d2d14a2) to head (7b6b043).
Report is 7 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mcache 93.99% <100.00%> (+0.50%) ⬆️
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@nubtron nubtron added this pull request to the merge queue Jan 10, 2025
Merged via the queue into master with commit 0ec4af3 Jan 10, 2025
47 checks passed
@nubtron nubtron deleted the keisku/mcache-check-ipv6-support branch January 10, 2025 14:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants