Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix broken embedded gstatus in GlusterFS check #19742

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

NouemanKHAL
Copy link
Member

@NouemanKHAL NouemanKHAL commented Mar 3, 2025

What does this PR do?

Fixes the usage of the gstatus CLI in the GlusterFS check.

The last gstatus release v1.0.9 is broken, since it doesn't list the module packaging as a dependency.

So we will start using our own fork to work around this issue.

Motivation

https://datadoghq.atlassian.net/browse/AGENT-13183

Testing

Manual for now. I will update the E2E tests catch such bugs in the future in a separate PR.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.03%. Comparing base (ba793f1) to head (2d9f872).

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
glusterfs 77.77% <100.00%> (-2.23%) ⬇️
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants