-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
adds gotk_resource_info metric to fluxcd metrics #19761
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
@@ -16,6 +16,7 @@ | |||
assert sorted(FLUX_V1_METRICS) == list(FLUX_V1_METRICS) | |||
|
|||
FLUX_V2_METRICS = { | |||
"gotk_resource_info": "gotk.resource.info", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! Do you mind adding this metric to the metadata.csv
? It would be great if we could add the output to the test fixtures as well
What does this PR do?
Adds the
gotk_resource_info
metric to the Fluxcd integration. Link to Fluxcd docsMotivation
Customer request
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged