Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adds gotk_resource_info metric to fluxcd metrics #19761

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lgh2
Copy link
Contributor

@lgh2 lgh2 commented Mar 5, 2025

What does this PR do?

Adds the gotk_resource_info metric to the Fluxcd integration. Link to Fluxcd docs

Motivation

Customer request

Review checklist (to be filled by reviewers)

  • [x ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.32%. Comparing base (b061755) to head (6ab5539).

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
fluxcd 88.31% <ø> (ø)
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -16,6 +16,7 @@
assert sorted(FLUX_V1_METRICS) == list(FLUX_V1_METRICS)

FLUX_V2_METRICS = {
"gotk_resource_info": "gotk.resource.info",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! Do you mind adding this metric to the metadata.csv? It would be great if we could add the output to the test fixtures as well

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants