Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[parametric] Update parametric tests for b3 trace context propagation headers #1627

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zacharycmontoya
Copy link
Contributor

@zacharycmontoya zacharycmontoya commented Sep 26, 2023

Description

Updates the test skip annotations for Ruby and C++ b3 trace context propagation header tests, including unskipping tests for Ruby on new tracer versions.

Motivation

Keeps the parametric test skip reasons up-to-date so we have a better understanding of why they are currently being skipped.

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@cbeauchesne
Copy link
Collaborator

Hi @zacharycmontoya , do you still plan to work on this ?

@zacharycmontoya zacharycmontoya changed the title [parametric] Run parametric tests on future standardized b3 headers [parametric] Update parametric tests for b3 trace context propagation headers Nov 14, 2024
…tests. They track the inverse of each other, so we only need to run one set tests. We are better off testing the behavior we want to enable, not the behavior we want to remove
@zacharycmontoya zacharycmontoya marked this pull request as ready for review November 14, 2024 18:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants