Skip to content

fix(sampling): update sample rate env var in parametric test #4499

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

genesor
Copy link
Member

@genesor genesor commented Apr 9, 2025

Motivation

One of the parametric test is using an env var that is not used anymore by the python client. DD_TRACE_SAMPLE_RATE has been dropped and replaced by DD_TRACE_SAMPLING_RULES

The test is currently passing due to an hardcoded sampling decision USER_KEEP in the http header extractor that is being reworked dd-trace-py#12950

Changes

  • add DD_TRACE_SAMPLING_RULES env var to Test_Decisionless_Extraction

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@genesor genesor requested review from mabdinur and a team as code owners April 9, 2025 08:05
@genesor genesor changed the title fix(sampling): add fix(sampling): update sample rate env var in parametric test Apr 9, 2025
@genesor genesor force-pushed the ben.db/APMAPI-1260-fix-parametric-sampling-rule branch from 61d0bdc to 40ddf12 Compare April 9, 2025 08:12
@genesor genesor merged commit e2fbef9 into main Apr 9, 2025
438 checks passed
@genesor genesor deleted the ben.db/APMAPI-1260-fix-parametric-sampling-rule branch April 9, 2025 08:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants