Fix SearchPanes and SearchBuilder not pre-filtering data #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11
This is my take on having SearchPanes and SearchBuilder handle a pre-filtered setup for editor.
1st, in
editor.cs
, expose the _GetWhere method internally:Then in SearchPaneOptions, apply the filtering twice by calling the above function with the query:
and again later:
Similarly, in SearchBuilder: