Skip to content

Commit

Permalink
CI: Move "Check Engines" job to its own workflow file
Browse files Browse the repository at this point in the history
  • Loading branch information
DeeDeeG committed Oct 28, 2023
1 parent 7cba0db commit 7564e32
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 17 deletions.
28 changes: 28 additions & 0 deletions .github/workflows/check-engines.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Check Engines

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]

permissions:
contents: read # to fetch code (actions/checkout)

jobs:
Engines:
runs-on: ubuntu-latest
steps:
- name: Checkout Repository
uses: actions/checkout@v3
- name: Use Node.js 20.x
uses: actions/setup-node@v3
with:
node-version: 20.x
- name: Install Dependencies
run: |
npm install --no-progress
- name: Check Engines
run: |
npm install @npmcli/arborist@7 semver@7 --no-save
node .github/scripts/check-engines.js
17 changes: 0 additions & 17 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,23 +18,6 @@ jobs:
- uses: actions/checkout@v4
- run: pip install --user ruff
- run: ruff --output-format=github --select="E,F,PLC,PLE,UP,W,YTT" --ignore="E721,PLC1901,S101,UP031" --target-version=py38 .
Engines:
runs-on: ubuntu-latest
steps:
- name: Checkout Repository
uses: actions/checkout@v3
- name: Use Node.js 20.x
uses: actions/setup-node@v3
with:
node-version: 20.x
- name: Install Dependencies
run: |
npm install --no-progress
- name: Check Engines
run: |
# TODO: move this to its own action
npm install @npmcli/arborist@7 semver@7 --no-save
node .github/scripts/check-engines.js
Tests:
needs: Lint_Python # Lint_Python takes ~5 seconds, so wait for it to pass before running the full matrix of tests.
strategy:
Expand Down

0 comments on commit 7564e32

Please # to comment.