Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add: some classifiers for python versions #49

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Add: some classifiers for python versions #49

merged 2 commits into from
Jul 28, 2021

Conversation

eggplants
Copy link
Contributor

I added some classifiers of Programming Language to setup.py.
This tiny change will improve the search slightly in PyPI.

Copy link
Member

@AlexEMG AlexEMG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about 3.8?

@eggplants
Copy link
Contributor Author

This program was not able to work correctly in Python 3.8 somehow.
It was probably because of the version of the library I was relying on.

@eggplants
Copy link
Contributor Author

Why is the version of numpy specified differently in setup.py and requirements.txt?
If everything is fine, you should read requirements.txt from within setup.py:

install_requires = open('requirements.txt').read().splitlines()

@MMathisLab
Copy link
Member

fair point @eggplants - sometimes we mod requirements.txt for rapid testing/forward testing, but indeed best practice would be to sync them.

@MMathisLab MMathisLab merged commit 4ac659a into DeepLabCut:master Jul 28, 2021
@eggplants
Copy link
Contributor Author

eggplants commented Aug 5, 2021

This program was not able to work correctly in Python 3.8 somehow.

@MMathisLab @AlexEMG
This instruction uses tensorflow(-gpu) 1.13.1.
They are only available on Python 3.4-3.6. tensorflow(-gpu) 2.5.0 (latest) are available on Python 3.6-3.8.
Now setup.py installs latest tensorflow, so If there are no problems I think we should update the instruction.

@eggplants
Copy link
Contributor Author

eggplants commented Aug 5, 2021

I'm wondering if I should put something in setup.py that determines if the GPU is available and installs tensorflow or tensorflow-gpu. I think it would be useful.

@MMathisLab
Copy link
Member

HI @eggplants the issue is that whatever version of TF was used tor train the model should be used to run it in DLC_live; both TF1 and all TF 2 versions are then compatible

@eggplants
Copy link
Contributor Author

@MMathisLab I didn't understand much about Tensorflow models. Thank you for the explanation.

@eggplants
Copy link
Contributor Author

install_requires.append("tensorflow")

Since the version is not specified here, if you have not installed Tensorflow beforehand and run pip install -e ., it will install the latest version of TF.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants