Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Mat][Trans] Add f32/f32x4 row/col first kernel #89

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

bear-zd
Copy link
Contributor

@bear-zd bear-zd commented Oct 17, 2024

Take a seat.

@DefTruth DefTruth changed the title [Mat Transpose] Add f32/f32x4(1d/2d theard, row first/col first) kernel. Add f32_diagonal kernel. Modify validate logic. [Mat Transpose] Add f32/f32x4 row/col first kernel Oct 18, 2024
@DefTruth DefTruth changed the title [Mat Transpose] Add f32/f32x4 row/col first kernel [Mat][Trans] Add f32/f32x4 row/col first kernel Oct 18, 2024
Copy link
Owner

@DefTruth DefTruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢您的贡献!修改以下几点后合入:

  • 删除未ready的代码,shared版本可以在下一个PR完成后合入
  • { }使用非对称风格
  • 一行代码尽量不要超100字符

@DefTruth DefTruth merged commit 293bc83 into DefTruth:main Oct 18, 2024
@DefTruth DefTruth mentioned this pull request Oct 18, 2024
43 tasks
@DefTruth
Copy link
Owner

DefTruth commented Oct 18, 2024

@bear-zd 增加了代码规范说明

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants