Azure Data Studio 1.31.0 Extension API

[Charles-Gagnon]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@Charles-Gagnon Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• azdata — on npm, on unpkg (author is owner)
  • owner-approval: @alanrenmsft
  • Config files to check:
    • azdata/tslint.json: not the expected form and not moving towards it (check: rules)

Code Reviews

Because this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 A DT maintainer needs to approve changes which affect module config files

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 54688,
  "author": "Charles-Gagnon",
  "headCommitOid": "e7455bdc35b68b2b12e35646c2929d49074962af",
  "lastPushDate": "2021-07-22T22:27:01.000Z",
  "lastActivityDate": "2021-07-23T17:18:44.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "azdata",
      "kind": "edit",
      "files": [
        {
          "path": "types/azdata/azdata-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/azdata/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/azdata/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) and not moving towards it (check: `rules`)"
        }
      ],
      "owners": [
        "Charles-Gagnon",
        "alanrenmsft",
        "kburtram",
        "kenvanhyning"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "alanrenmsft",
      "date": "2021-07-23T17:18:44.000Z",
      "isMaintainer": false
    },
    {
      "type": "stale",
      "reviewer": "kburtram",
      "date": "2021-07-22T21:42:09.000Z",
      "abbrOid": "ec35c78"
    }
  ],
  "mainBotCommentID": 885252501,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @alanrenmsft @kburtram @kenvanhyning — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[kburtram]

LGTM.

[typescript-bot]

@Charles-Gagnon The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@Charles-Gagnon The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@kburtram Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[Charles-Gagnon]

@kburtram @alanrenmsft @kenvanhyning Could one of you please sign off on this?

[sandersn]

Seems like unified-signatures should add an exception when any of the signatures is deprecated.

Edit: microsoft/dtslint#337

[Charles-Gagnon]

Agreed, thank you for submitting that!

[typescript-bot]

I just published @types/azdata@1.31.0 to npm.