Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add typings for exif-reader #62942

Merged
merged 5 commits into from
Oct 28, 2022

Conversation

akwodkiewicz
Copy link
Contributor

@akwodkiewicz akwodkiewicz commented Oct 28, 2022

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 28, 2022

@akwodkiewicz Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 62942,
  "author": "akwodkiewicz",
  "headCommitOid": "b672f95ce51d42cc4fc546e2ab166d210bede981",
  "mergeBaseOid": "b35434fe6f6f0be1c78a5b4bc62d2368525ebcd4",
  "lastPushDate": "2022-10-28T07:57:06.000Z",
  "lastActivityDate": "2022-10-28T20:56:59.000Z",
  "mergeOfferDate": "2022-10-28T16:20:23.000Z",
  "mergeRequestDate": "2022-10-28T20:56:59.000Z",
  "mergeRequestUser": "akwodkiewicz",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "exif-reader",
      "kind": "add",
      "files": [
        {
          "path": "types/exif-reader/exif-reader-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/exif-reader/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/exif-reader/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/exif-reader/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "akwodkiewicz"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2022-10-28T16:19:35.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1294497127,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Check Config Changes a module config files labels Oct 28, 2022
@typescript-bot
Copy link
Contributor

🔔 @akwodkiewicz — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Oct 28, 2022
@typescript-bot
Copy link
Contributor

@akwodkiewicz The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added The CI failed When GH Actions fails and removed The CI failed When GH Actions fails Check Config Changes a module config files labels Oct 28, 2022
@typescript-bot
Copy link
Contributor

@akwodkiewicz The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added The CI failed When GH Actions fails and removed The CI failed When GH Actions fails labels Oct 28, 2022
@typescript-bot
Copy link
Contributor

@akwodkiewicz The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Oct 28, 2022
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 28, 2022
@typescript-bot
Copy link
Contributor

@akwodkiewicz: Everything looks good here. I am ready to merge this PR (at b672f95) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@akwodkiewicz
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit f65dd44 into DefinitelyTyped:master Oct 28, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Maintainer Approved New Definition This PR creates a new definition package. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants