fix(xmiwrapper): fix error with relative dll paths on Windows #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* On Windows a relative lib_dependency path results in `OSError: [WinError 87] The parameter is incorrect` Closes Deltares#113
Codecov Report
@@ Coverage Diff @@
## develop #114 +/- ##
========================================
Coverage 87.92% 87.92%
========================================
Files 7 7
Lines 530 530
========================================
Hits 466 466
Misses 64 64
|
Hofer-Julian
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Thanks @jdhughes-usgs!
I think your change is also valid for macOS and Linux, so I've added 0aac516 to your branch.
If you agree, we can merge this PR.
|
@Hofer-Julian I agree. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSError: [WinError 87] The parameter is incorrectCloses #113