Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Always run tests/test_mf6_disu_bmi.py::test_get_grid_nodes_per_face #77

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Jun 28, 2022

I had intended to add a xfail marker for this test, but it seems to work as expected under Linux, so re-activating the test.

Also, add a RuntimeError when testing with other operating systems than Linux, Windows or macOS.

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #77 (8512fde) into develop (21192db) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #77   +/-   ##
========================================
  Coverage    85.52%   85.52%           
========================================
  Files            6        6           
  Lines          442      442           
========================================
  Hits           378      378           
  Misses          64       64           

@Hofer-Julian
Copy link
Contributor

Yes, I think we fixed that error, but forgot to update this specific test.

@Hofer-Julian Hofer-Julian merged commit 49e3576 into Deltares:develop Jun 28, 2022
@Hofer-Julian
Copy link
Contributor

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants