Corrected valid extensions to fix archive loading of GB/GBC #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. |
|
I submitted the same PR to main libretro bsnes at libretro/bsnes#40, so if you're going to resync for the next version this one may be unnecessary. Feel free to close it if so. |
|
absorbed by #69 (and included in beta10.4) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently loading GB/GBC files from within an archive in this core throws an error and doesn't extract the file to the cache directory. The game still runs, but it interferes with all operations relying on a cached copy of the file. Adding gb and gbc to supported extensions remedies this issue.