Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[#13] parsing xml fix - parsing CDATA and comments #17

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

mari6274
Copy link
Contributor

@mari6274 mari6274 commented Nov 8, 2018

Example:

...
<testcase name="Variance_V1" status="run" time="0" classname="Covariances_Tests" />
<!--some comment--><testcase name="Covariance" status="run" time="0" classname="Covariances_Tests" />
...

In this case parser after processing comment skips char < and whole next testcase element is skipped in result. The same occurs while using CDATA:

...
<testcase name="Variance_V1" status="run" time="0" classname="Covariances_Tests" /><!CDATA[some data
]]>--><testcase name="Covariance" status="run" time="0" classname="Covariances_Tests" />
...

The problem is index i is incremented too much because for-loop increment it once more.
The solution is incrementing 1 down.

@johanneswilm johanneswilm merged commit 2f7125a into DesignLiquido:master Nov 9, 2018
@johanneswilm
Copy link
Contributor

@mari6274 thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants