Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: WG-400 absolute URLs and broken links #112

Merged
merged 56 commits into from
Jan 24, 2025

Conversation

wesleyboar
Copy link
Collaborator

@wesleyboar wesleyboar commented Jan 13, 2025

Overview / Status / Changes

  • Use relative URLs not absolute URLs for internal links.
  • Fix broken links to /rw/user-guides.
  • Ensure all /rw/ links work or are fixed.
  • Use Markdown not HTML for many links.
  • Record what to test.
  • Test.
  • (New PR) Use Markdown not HTML for all links.

Related

Testing

  1. Run/Deploy this branch.
  2. Review changed links.
    (test.md has list of changed pages, with nested list of changed links)
  3. Test changed links.
  4. Verify external links open in new tab.

Notes

Note

http://0.0.0.0:8000/user-guide/tools/jupyterhub/ page's directly via https://jupyter.designsafe-ci.org link is appending /jupyterhub most of the time I test. I do not know why, because the source document does not have that.

@wesleyboar wesleyboar changed the title fix: WG-400 dabsolute URLs and broken links fix: WG-400 absolute URLs and broken links Jan 13, 2025
@wesleyboar wesleyboar marked this pull request as ready for review January 24, 2025 19:57
@wesleyboar wesleyboar merged commit 53ca07d into main Jan 24, 2025
@wesleyboar wesleyboar deleted the fix/WG-400-abs-urls-and-broken-links branch January 24, 2025 21:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant