Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug] Fix calculation of move base power #658

Draft
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

DayKev
Copy link
Contributor

@DayKev DayKev commented Feb 12, 2025

What are the changes the user will see?

Move base power will be calculated correctly.

Why am I making these changes?

Move base power calculation is incorrect.

What are the changes from a developer perspective?

Renamed VariablePowerAttr to VariableBasePowerAttr.
Moved application of VariableBasePowerAttr and VariableMovePowerAbAttr to before terastallization base power boost.

Additionally, moves of the Tera Type that have a base power below 60 are increased to 60 base power; this is checked for after Technician's boost [3].

Relevant changes in src/data/move.ts

Screenshots/Videos

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test:silent)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?

@DayKev DayKev added Move For move implementations/interactions P2 Bug Minor bug. Used for when a move/ability/interaction is incorrect but is not game breaking. labels Feb 12, 2025
@Snailman11
Copy link
Contributor

Wondering if this fixes its interaction with Aerilate, where the damage increase is overwritten.

@DayKev
Copy link
Contributor Author

DayKev commented Feb 14, 2025

It should.

@DayKev DayKev force-pushed the bug/fix-moveattr-application-order branch 2 times, most recently from 115e338 to bef8c21 Compare February 14, 2025 03:33
@DayKev DayKev force-pushed the bug/fix-moveattr-application-order branch from bef8c21 to 28ee298 Compare February 14, 2025 04:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Move For move implementations/interactions P2 Bug Minor bug. Used for when a move/ability/interaction is incorrect but is not game breaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants