Work around downshift+autofocus regression #9049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robojumper
commented
Feb 2, 2023
| @@ -316,14 +322,15 @@ function SearchBar( | |||
| return { | |||
| ...changes, | |||
| selectedItem: state.selectedItem, // keep the last selected item (i.e. the edit field stays unchanged) | |||
| closeMenu: true, // close the menu | |||
There was a problem hiding this comment.
This is not advertised in the types and Downshift doesn't seem to read it.
bhollis
approved these changes
Feb 2, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to improve accessibility, downshift.js v7.0.0 opens the menu when the input receives focus: downshift-js/downshift#1439 / downshift-js/downshift#1440.
This means the item picker sheets will now show the search completion dropdown directly when opening them since they have autofocus (e.g. in loadouts, LO's subclass picker, ...), making the item picker much less useful.
From the issue comments, downshift will likely switch to using explicit clicks for opening/closing, but this just restores the previous behavior until downshift can figure its stuff out.