Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Warn on mnc usage #102

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Warn on mnc usage #102

merged 4 commits into from
Jan 21, 2025

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Jan 21, 2025

Description
Checklist
  • Tested changes against a test repository
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

src/helpers.ts Outdated Show resolved Hide resolved
src/helpers.ts Outdated Show resolved Hide resolved
src/mnc-warn.ts Outdated Show resolved Hide resolved
"With:",
newLine,
"",
"For more details: https://dtr.mn/magic-nix-cache-eol",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"For more details: https://dtr.mn/magic-nix-cache-eol",
"For more details: https://dtr.mn/magic-nix-cache-eol",

Note: this URL does not yet exist, but we can merge anyway. This change is feature flagged off until the blog post is finished.

@grahamc grahamc marked this pull request as ready for review January 21, 2025 17:24
src/mnc-warn.ts Outdated Show resolved Hide resolved
src/mnc-warn.ts Outdated Show resolved Hide resolved
src/mnc-warn.ts Outdated Show resolved Hide resolved
@grahamc grahamc added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 6221693 Jan 21, 2025
5 checks passed
@grahamc grahamc deleted the warn-on-mnc branch January 21, 2025 17:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants