Complaints #47

preetamozarde3 · 2019-02-06T07:55:40Z

The following changes have been made in this branch:

A complaint/suggestions module has been added to the app.
A complaint/suggestions tab has been added in the navigation bar, on the clicking of which the user is taken to the complaints home page.
On this page, the user can:
- View all the complaints posted in the app.
- Up vote a complaint if they are in support of it.
- Subscribe to a particular complaint.
- Navigate to the complaint details page to view the details of a particular complaint by clicking on the complaint card.
- Navigate to the file complaints page to post a new complaint by clicking on the 'Vent your issues' button at the top of the page.
The file complaints page allows the user to file a new complaint. They can add the following information along with the description to give a more complete account of their issue:
- Images, suggestions, location details and tags
The complaint details page has the following features:
- The users can view the description, suggestions and location details added by the creator.
- The users can view the images and tags (if any) associated with the complaint.
- The users can comment, up vote or subscribe to the complaint if the wish.
All the components along with the associated HTML and CSS files for the aforementioned three pages have been added to a new folder named venter.
Apart from this, additions have been made to the nav menu, data service, interfaces, API and assets.

pulsejet

@preetamozarde3 I haven't been through everything, but have highlighted a few issues here. You might want to use an IDE like VS Code that has linting built in to fix lint issues.

pulsejet · 2019-02-06T13:16:24Z

package.json

+    "@angular-devkit/build-angular": "^0.13.0",
+    "@angular/cli": "^7.0.2",
+    "@angular/compiler-cli": "^7.0.0",
+    "@angular/language-service": "^7.0.0",


Please don't change anything in package.json and package-lock.json

pulsejet · 2019-02-06T13:17:32Z

src/app/app.module.ts

+import { MatButtonModule } from '@angular/material/button';
+import { MatDialogModule } from '@angular/material';
+import { DetailedComplaintComponent } from './venter/detailed-complaint/detailed-complaint.component';
+import { MatDividerModule } from '@angular/material/divider';


All these imports don't belong here. Most of them are already imported in material-angular.module.ts. Any extra @angular/material module imports should be placed there.

pulsejet · 2019-02-06T13:18:18Z

src/app/app.module.ts

@@ -100,6 +119,21 @@ import { CardComponent } from './card/card.component';
    HttpClientModule,
    FormsModule,
    BrowserAnimationsModule,
+    AgmCoreModule.forRoot({
+      apiKey: 'AIzaSyCKNBwrs1UdT2s1jwqOypSzas9Z4s6h4B0'


Never commit API keys

I thought we were not going to use google maps here?

pulsejet · 2019-02-06T13:19:20Z

src/app/app.module.ts

@@ -121,6 +155,10 @@ import { CardComponent } from './card/card.component';
      { path: 'settings', component: SettingsComponent, data: { state: 'base' } },
      { path: 'about', component: AboutComponent, data: { state: 'overlay' } },

+      { path: 'venter/complaints-home', component: ComplaintsHomeComponent, data: { state: 'base' } },
+      { path: 'venter/file-complaint', component: FileComplaintComponent, data: { state: 'base' } },
+      { path: 'venter/detailed-complaint/:id', component: DetailedComplaintComponent, data: { state: 'base' } },


Place these between login and feedback with a whitespace above and below

pulsejet · 2019-02-06T13:19:53Z

src/app/data.service.ts

+
+  GetComplaint(uuid: string): Observable<IComplaint> {
+    return this.FireGET<IComplaint>(API.Complaint, {uuid: uuid});
+  }


Is this really necessary? I can hardly imaging this function being called in more than two places.

pulsejet · 2019-02-06T13:41:13Z

src/app/venter/detailed-complaint/detailed-complaint.component.html

+    <br>
+
+    <a button class="upVote-button" (click)="upVoteComplaint(detailedComplaint.upvoted)">
+        UPVOTE


Change this to a mat button

pulsejet · 2019-02-06T13:41:40Z

src/app/venter/detailed-complaint/detailed-complaint.component.ts

+import { API } from '../../../api';
+import * as moment from 'moment';
+
+


Extra whitespace

pulsejet · 2019-02-06T13:42:13Z

src/app/venter/detailed-complaint/detailed-complaint.component.ts

+          this.statusColor = 'red';
+        } else if (this.detailedComplaint.status === 'Resolved') {
+          this.statusColor = 'green';
+        } else if (this.detailedComplaint.status === 'In progress') {


Same as above; you could refactor this to a different file altogether

pulsejet · 2019-02-06T13:42:19Z

src/app/venter/detailed-complaint/detailed-complaint.component.ts

+    if (this.complaintId) {
+      this.dataService.FireGET<IComplaint>(API.Complaint, { complaintId: this.complaintId }).subscribe(result => {
+        this.detailedComplaint = result;
+        console.log(this.detailedComplaint);


pulsejet · 2019-02-06T13:43:27Z

src/assets/placeholder_image.svg

+</g>
+<g>
+</g>
+<g>


Remove these empty tags

preetamozarde3 added 3 commits February 6, 2019 12:17

Added a complaints/suggestions module

bc78eef

Pull changes from the master to make it upto date with feature branch

d0ab16a

Minor Codacy Changes

9ce0d43

DevCom-IITB deleted a comment Feb 6, 2019

Make minor codacy changes

805109f

DevCom-IITB deleted a comment Feb 6, 2019

Make minor codacy adjustments

a8e5d0c

DevCom-IITB deleted a comment Feb 6, 2019

preetamozarde3 closed this Feb 6, 2019

pulsejet reviewed Feb 6, 2019

View reviewed changes

pulsejet mentioned this pull request Feb 8, 2019

Complaints suggestions #49

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Complaints #47

Complaints #47

preetamozarde3 commented Feb 6, 2019

pulsejet left a comment •

edited

Loading

pulsejet Feb 6, 2019

pulsejet Feb 6, 2019

pulsejet Feb 6, 2019

pulsejet Feb 6, 2019

pulsejet Feb 6, 2019

pulsejet Feb 6, 2019

pulsejet Feb 6, 2019

pulsejet Feb 6, 2019

pulsejet Feb 6, 2019

pulsejet Feb 6, 2019

		import { API } from '../../../api';
		import * as moment from 'moment';

Complaints #47

Complaints #47

Conversation

preetamozarde3 commented Feb 6, 2019

pulsejet left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pulsejet left a comment •

edited

Loading